On Wed Mar 19, 2025 at 10:36 PM UTC, Martin Blumenstingl wrote: > Hello, > > thanks for your contribution and sorry for the late reply! > > On Wed, Mar 19, 2025 at 8:02 PM Ferass El Hafidi > <funderscore@xxxxxxxxxxxxxxxx> wrote: > [...] > > + au2: analog-amplifier { > > + compatible = "simple-audio-amplifier"; > > + sound-name-prefix = "AU2"; > > + VCC-supply = <&vcc_5v>; > > + enable-gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>; > > + }; > I couldn't find any pictures online that show an analog audio output > (typically a 3.5mm socket). > Can you confirm that this is really present? > > [...] > > + sound { > > + compatible = "amlogic,gx-sound-card"; > > + model = "XIAOMI-AQUAMAN"; > > + audio-aux-devs = <&au2>; > > + audio-widgets = "Line", "Lineout"; > > + audio-routing = "AU2 INL", "ACODEC LOLN", > > + "AU2 INR", "ACODEC LORN", > > + "Lineout", "AU2 OUTL", > > + "Lineout", "AU2 OUTR"; > If there's no analog audio in/out then this section can be cleaned up > as well - together with the references to acodec in the dai-links > below. Oops, completely overlooked those. Will fix in v6. There indeed is no analog audio output. > > [...] > > +/* Wireless SDIO Module (Amlogic W155S1 / Realtek RTL8821CS) */ > > +&sd_emmc_b { > question to Neil: since we know that there's two board variants out > there (with different wifi chipsets) - are dt overlays down the road > enough (to enable Bluetooth / wifi - depending on the chipset or board > revision) or do we need to split the whole .dts? > So far W155S1 and RTL8821CS are the *known* chipsets used, but there may be others. Right now it's not my main concern, as W155S1 is not supported in Mainline, as far as I know, and I can't test RTL8821CS because my variant seems to have the former. > > Best regards, > Martin Regards.