Re: [PATCH v5 09/11] input: keyboard: Add support for MAX7360 keypad

[kernel test robot <lkp@xxxxxxxxx>]

Hi Mathieu,

kernel test robot noticed the following build errors:

[auto build test ERROR on a64dcfb451e254085a7daee5fe51bf22959d52d3]

url:    https://github.com/intel-lab-lkp/linux/commits/Mathieu-Dubois-Briand/dt-bindings-mfd-gpio-Add-MAX7360/20250319-003750
base:   a64dcfb451e254085a7daee5fe51bf22959d52d3
patch link:    https://lore.kernel.org/r/20250318-mdb-max7360-support-v5-9-fb20baf97da0%40bootlin.com
patch subject: [PATCH v5 09/11] input: keyboard: Add support for MAX7360 keypad
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20250319/202503192258.ULXxG0T4-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250319/202503192258.ULXxG0T4-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503192258.ULXxG0T4-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   drivers/input/keyboard/max7360-keypad.c: In function 'max7360_keypad_irq':
>> drivers/input/keyboard/max7360-keypad.c:57:8: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
     row = FIELD_GET(MAX7360_FIFO_ROW, val);
           ^~~~~~~~~
   drivers/input/keyboard/max7360-keypad.c: In function 'max7360_keypad_hw_init':
>> drivers/input/keyboard/max7360-keypad.c:114:5: error: implicit declaration of function 'FIELD_PREP'; did you mean 'EV_REP'? [-Werror=implicit-function-declaration]
        FIELD_PREP(MAX7360_DEBOUNCE, val));
        ^~~~~~~~~~
        EV_REP
   cc1: some warnings being treated as errors


vim +/FIELD_GET +57 drivers/input/keyboard/max7360-keypad.c

    29	
    30	static irqreturn_t max7360_keypad_irq(int irq, void *data)
    31	{
    32		struct max7360_keypad *max7360_keypad = data;
    33		unsigned int val;
    34		unsigned int row, col;
    35		unsigned int release;
    36		unsigned int code;
    37		int ret;
    38	
    39		do {
    40			ret = regmap_read(max7360_keypad->regmap, MAX7360_REG_KEYFIFO, &val);
    41			if (ret) {
    42				dev_err(&max7360_keypad->input->dev, "Failed to read max7360 FIFO");
    43				return IRQ_NONE;
    44			}
    45	
    46			/* FIFO overflow: ignore it and get next event. */
    47			if (val == MAX7360_FIFO_OVERFLOW)
    48				dev_warn(&max7360_keypad->input->dev, "max7360 FIFO overflow");
    49		} while (val == MAX7360_FIFO_OVERFLOW);
    50	
    51		if (val == MAX7360_FIFO_EMPTY) {
    52			dev_dbg(&max7360_keypad->input->dev, "Got a spurious interrupt");
    53	
    54			return IRQ_NONE;
    55		}
    56	
  > 57		row = FIELD_GET(MAX7360_FIFO_ROW, val);
    58		col = FIELD_GET(MAX7360_FIFO_COL, val);
    59		release = val & MAX7360_FIFO_RELEASE;
    60	
    61		code = MATRIX_SCAN_CODE(row, col, MAX7360_ROW_SHIFT);
    62	
    63		dev_dbg(&max7360_keypad->input->dev, "key[%d:%d] %s\n", row, col,
    64			release ? "release" : "press");
    65	
    66		input_event(max7360_keypad->input, EV_MSC, MSC_SCAN, code);
    67		input_report_key(max7360_keypad->input, max7360_keypad->keycodes[code], !release);
    68		input_sync(max7360_keypad->input);
    69	
    70		return IRQ_HANDLED;
    71	}
    72	
    73	static int max7360_keypad_open(struct input_dev *pdev)
    74	{
    75		struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev);
    76		int ret;
    77	
    78		/*
    79		 * Somebody is using the device: get out of sleep.
    80		 */
    81		ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG,
    82					MAX7360_CFG_SLEEP, MAX7360_CFG_SLEEP);
    83		if (ret) {
    84			dev_err(&max7360_keypad->input->dev,
    85				"Failed to write max7360 configuration\n");
    86			return ret;
    87		}
    88	
    89		return 0;
    90	}
    91	
    92	static void max7360_keypad_close(struct input_dev *pdev)
    93	{
    94		struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev);
    95		int ret;
    96	
    97		/*
    98		 * Nobody is using the device anymore: go to sleep.
    99		 */
   100		ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG, MAX7360_CFG_SLEEP, 0);
   101		if (ret)
   102			dev_err(&max7360_keypad->input->dev,
   103				"Failed to write max7360 configuration\n");
   104	}
   105	
   106	static int max7360_keypad_hw_init(struct max7360_keypad *max7360_keypad)
   107	{
   108		unsigned int val;
   109		int ret;
   110	
   111		val = max7360_keypad->debounce_ms - MAX7360_DEBOUNCE_MIN;
   112		ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_DEBOUNCE,
   113					MAX7360_DEBOUNCE,
 > 114					FIELD_PREP(MAX7360_DEBOUNCE, val));
   115		if (ret) {
   116			return dev_err_probe(&max7360_keypad->input->dev, ret,
   117				"Failed to write max7360 debounce configuration\n");
   118		}
   119	
   120		ret = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_INTERRUPT,
   121					MAX7360_INTERRUPT_TIME_MASK,
   122					FIELD_PREP(MAX7360_INTERRUPT_TIME_MASK, 1));
   123		if (ret) {
   124			return dev_err_probe(&max7360_keypad->input->dev, ret,
   125				"Failed to write max7360 keypad interrupt configuration\n");
   126		}
   127	
   128		return 0;
   129	}
   130	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki