On Tue, Mar 18, 2025 at 09:37:29AM -0700, Guenter Roeck wrote: > > > > +patternProperties: > > > > + '^fan@[0-4]$': > > > > + $ref: fan-common.yaml# > > > > + unevaluatedProperties: false > > > > + properties: > > > > + reg: > > > > + description: > > > > + The fan number used to determine the associated PWM channel. > > > > + > > > > + required: > > > > + - reg > > > > + - pwms > > > > > > Is it necessary to make 'pwms' mandatory ? The current code works > > > just fine with defaults. > > > > The code adding OF support is added just in the next patch, so the > > current code isn't event > > probed when trying to use dts. > > > > Or am I missing something? > > > > The patch introducing devicetree support to the driver doesn't evaluate > the pwm property. That makes it quite obvious that, from driver perspective, > it isn't needed. I don't immediately see why it would add value to _force_ > users to provide pwm frequency, polarity, and the output configuration > if the defaults work just fine. Indeed. PWM source is actually fixed and rest of pwm argument could be fine with defaults. Both options are fine with me, so keep my tag. Best regards, Krzysztof
