On Fri, 2025-03-14 at 19:21 +0800, Kevin Chen wrote:
> + pcc->mdev.parent = dev;
> + pcc->mdev.minor = MISC_DYNAMIC_MINOR;
> + pcc->mdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
> DEVICE_NAME,
> + pcc->mdev_id);
> + pcc->mdev.fops = &pcc_fops;
> + rc = misc_register(&pcc->mdev);
> + if (rc) {
> + dev_err(dev, "Couldn't register misc device\n");
> + goto err_free_ida;
> + }
Just a note that this still isn't accounting for discussion on the
previous posting of the series putting the driver under
drivers/soc/aspeed:
https://lore.kernel.org/all/f7369d6205e05c7aac3f3de7cbd08c3b08960d75.camel@xxxxxxxxxxxxxxxxxxxx/
If we're not going to try make a common userspace behaviour over the
Aspeed snoop and PCC functions and the Nuvoton BPC function then I
think the behaviour of the chardev should at least be documented. But I
would rather that it were common to avoid headaches in userspace.
Andrew
