On Sat, Mar 15, 2025 at 09:12:12AM +0100, John Madieu wrote: > The Renesas RZ/G3E SoC includes a Thermal Sensor Unit (TSU) block designed > to measure the junction temperature. The device provides real-time temperature > measurements for thermal management, utilizing a single dedicated channel > (channel 1) for temperature sensing. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Please run scripts/checkpatch.pl and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> > --- > v1 -> v2: > * Fix reg property specifier to get rid of yamlint warnings > * Fix IRQ name to reflect TSU expectations ... > + interrupts: > + description: | > + Interrupt specifiers for the TSU: > + - S12TSUADI1: Conversion complete interrupt signal (pulse) > + - S12TSUADCMPI1: Comparison result interrupt signal (level) Same problems as before - you need to list and describe items to have constraints. Otherwise why 5 interrupts are allowed but only two interrupt-names (test this)? There is no syntax like above in any other bindings. If you found such, please share the filename so we can fix it. > + > + interrupt-names: > + items: > + - const: adi > + - const: adcmpi > + > + "#thermal-sensor-cells": > + const: 0 > + > + renesas,tsu-calibration-sys: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + Phandle to the system controller (sys) that contains the TSU > + calibration values used for temperature calculations. > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + - interrupts > + - interrupt-names > + - "#thermal-sensor-cells" > + - renesas,tsu-calibration-sys > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/renesas,r9a09g047-cpg.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + tsu: thermal@14002000 { > + compatible = "renesas,r9a09g047-tsu"; > + reg = <0x14002000 0x1000>; > + clocks = <&cpg CPG_MOD 0x10a>; > + resets = <&cpg 0xf8>; > + power-domains = <&cpg>; > + interrupts = <GIC_SPI 250 IRQ_TYPE_EDGE_RISING>, > + <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "adi", "adcmpi"; > + #thermal-sensor-cells = <0>; > + renesas,tsu-calibration-sys = <&sys>; > + }; > + > + thermal-zones { Drop the node, no need to show how to use provider binding. Best regards, Krzysztof
