Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 14 March 2025 13:40 > Subject: Re: [PATCH v4 02/11] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3E support > > Hi Biju, > > On Thu, 6 Mar 2025 at 13:43, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Document support for the CAN-FD Interface on the RZ/G3E (R9A09G047) > > SoC, which supports up to six channels. > > > > The CAN-FD module on RZ/G3E is very similar to the one on both R-Car > > V4H and RZ/G2L, but differs in some hardware parameters: > > * No external clock, but instead has ram clock. > > * Support up to 6 channels. > > * 20 interrupts. > > > > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > --- > > a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yam > > +++ l > > > @@ -173,7 +204,9 @@ allOf: > > properties: > > compatible: > > contains: > > - const: renesas,rzg2l-canfd > > + enum: > > + - renesas,r9a09g047-canfd > > + - renesas,rzg2l-canfd > > Not having this common rule, and keeping interrupts and resets together would allow you to keep a > clear separation between RZ/G2L and RZ/G3E, at the expense of only a single line. I agree, this will make clear separation. Rob,Conor, Krzysztof, Marc: The suggested changes are trivial and is just sorting the properties for clear separation. I will be sending V5 for this. Cheers, Biju
