Hi Biju,
On Thu, 6 Mar 2025 at 13:43, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Document support for the CAN-FD Interface on the RZ/G3E (R9A09G047) SoC,
> which supports up to six channels.
>
> The CAN-FD module on RZ/G3E is very similar to the one on both R-Car V4H
> and RZ/G2L, but differs in some hardware parameters:
> * No external clock, but instead has ram clock.
> * Support up to 6 channels.
> * 20 interrupts.
>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> @@ -173,7 +204,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: renesas,rzg2l-canfd
> + enum:
> + - renesas,r9a09g047-canfd
> + - renesas,rzg2l-canfd
Not having this common rule, and keeping interrupts and resets together
would allow you to keep a clear separation between RZ/G2L and RZ/G3E,
at the expense of only a single line.
> then:
> properties:
> resets:
> @@ -187,6 +220,19 @@ allOf:
> required:
> - reset-names
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a09g047-canfd
> + then:
> + properties:
> + interrupts:
> + minItems: 20
> +
> + interrupt-names:
> + minItems: 20
> +
> - if:
> properties:
> compatible:
> @@ -219,6 +265,15 @@ allOf:
> patternProperties:
> "^channel[4-7]$": false
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a09g047-canfd
> + then:
> + patternProperties:
> + "^channel[6-7]$": false
> +
> unevaluatedProperties: false
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
