Re: [PATCH v3 1/3] dt-bindings: display: tegra: document EPP, ISP, MPE and TSEC for Tegra114 and Tegra124

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



пт, 14 бер. 2025 р. о 10:11 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
>
> On 14/03/2025 08:59, Svyatoslav Ryhel wrote:
> > пт, 14 бер. 2025 р. о 09:56 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
> >>
> >> On 14/03/2025 08:45, Svyatoslav Ryhel wrote:
> >>> The current EPP, ISP and MPE schemas are largely compatible with Tegra114
> >>> and Tegra124, requiring only minor adjustments. Additionally, the TSEC
> >>> schema for the Security engine, which is available from Tegra114 onwards,
> >>> is included.
> >>>
> >>> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> >>
> >> <form letter>
> >> This is a friendly reminder during the review process.
> >>
> >> It seems my or other reviewer's previous comments were not fully
> >> addressed. Maybe the feedback got lost between the quotes, maybe you
> >> just forgot to apply it. Please go back to the previous discussion and
> >> either implement all requested changes or keep discussing them.
> >>
> >> Thank you.
> >> </form letter>
> >>
> >
> > I kept reset-names for TSEC since it seems that it is needed, ask
>
>
> reset-names are not needed and the rest is not applied. I don't see
> opp-table either.

You are exaggerating, I have either changed as you asked or removed
property if I cannot provide needed change. About reset-name I
mentioned in the changelog and I would like to hear what Thierry
thinks about this. About opp-table be more specific please, do I need
to provide an opp table in the example, or include some yaml
reference, or what? That would be really helpful.

>
> You didn't bother to acknowledge nor respond to comments, so it is
> expected you will implement it fully. Not me to keep checking if you
> read each comment and decided to silently ignore it.
>
>
> Best regards,
> Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux