Hi,
On Thu, Mar 13, 2025 at 07:07:24AM +0100, Jernej Škrabec wrote:
Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
Add the corresponding nodes to the device tree.
Signed-off-by: Michael Klein <michael@xxxxxxxxxxxx>
This is patch 2/2. Which one is patch 1/2? I got only one.
https://patchwork.kernel.org/project/netdevbpf/patch/20250312193629.85417-1-michael@xxxxxxxxxxxx/
Sorry for any inconvenience in case I messed up the patch submission.
I made two commits for this change and submitted them via `git send-email
HEAD^^`. The first patch went to netdev@xxxxxxxxxxxxxxx, the second
to linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, which seems logical. Have I
done something wrong?
Best regards,
Jernej
Michael
---
.../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
index 46ecf9db2324..4976453ed192 100644
--- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
+++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
@@ -48,6 +48,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
/ {
model = "LeMaker Banana Pi";
@@ -169,6 +170,32 @@ &ir0 {
&gmac_mdio {
phy1: ethernet-phy@1 {
reg = <1>;
+
+ leds {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_GREEN>;
+ default-state = "keep";
+ linux,default-trigger = "netdev";
+ };
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_AMBER>;
+ default-state = "keep";
+ linux,default-trigger = "netdev";
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_BLUE>;
+ default-state = "keep";
+ linux,default-trigger = "netdev";
+ };
+ };
};
};
--
