On 2025-03-12 10:54 AM, Suraj Gupta wrote:
AXI 1G/2.5G ethernet IP has following synthesis options:
1) SGMII/1000base-X only.
2) 2500base-X only.
3) dynamically switching between (1) and (2).
Add support for 2500base-X only configuration.
Hi, thanks for the patch.
nit: a discrepancy between the commit description for and the comments
in the code for 3)
Maybe adding that information here in the commit description would make
sense as well? Or giving a bit of a background that SGMII/1000base-X is
already implemented in the driver and you are adding 2500base-X only
support.
+ /* AXI 1G/2.5G ethernet IP has following synthesis options:
+ * 1) SGMII/1000base-X only.
+ * 2) 2500base-X only.
+ * 3) Dynamically switching between (1) and (2), and is not
+ * implemented in driver.
+ */
For the rest of the patch, it looks good to me but I'd rather have
someone more experienced provide the Reviewed-By tag if they find the
patch appropriate.
Best regards,
Dawid
