Re: [PATCH] arm64: dts: qcom: qcs8300: add the pcie smmu node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/12/2025 2:14 PM, Dmitry Baryshkov wrote:
On Wed, Mar 12, 2025 at 12:41:38PM +0530, Pratyush Brahma wrote:
On 3/12/2025 12:23 PM, Dmitry Baryshkov wrote:
On Thu, Feb 06, 2025 at 07:13:17PM +0530, Pratyush Brahma wrote:
Add the PCIe SMMU node to enable address translations
for pcie.

Signed-off-by: Pratyush Brahma <quic_pbrahma@xxxxxxxxxxx>
---
   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 75 +++++++++++++++++++++++++++++++++++
   1 file changed, 75 insertions(+)

Reviewed-by: Dmitry Baryshkov <lumag@xxxxxxxxxx>

Though I see a little benefit in having this SMMU node if it is not
followed by the PCIe enablement.
Thanks for the review!

PCIe enablement changes for qcs8300 have been posted already [1] and [1]
needs
this patch as mentioned in [2].
Ack. In future please consider posting series in a logical way: if PCIe
SMMU is only useful for PCIe and it is required for PCIe to work it
makes much more sense to have it as a part of the PCIe enablement series
rather than having it as a separate patch which can easily get lost.
Sure, will keep this in mind further.

[1] https://lore.kernel.org/lkml/20250310063103.3924525-8-quic_ziyuzhan@xxxxxxxxxxx
[2] https://lore.kernel.org/lkml/20250310063103.3924525-1-quic_ziyuzhan@xxxxxxxxxxx

--
Thanks and Regards
Pratyush Brahma

--
Thanks and Regards
Pratyush Brahma





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux