> Mark Brown <broonie@xxxxxxxxxx> hat am 7. Mai 2015 um 20:52 geschrieben: > > > On Thu, May 07, 2015 at 08:37:18PM +0200, Stefan Wahren wrote: > > > Stefan Wahren <stefan.wahren@xxxxxxxx> hat am 4. Mai 2015 um 22:34 > > > > i'm sorry, i forgot the following point in the changelog: > > > > - move dcdc handling from mxs_power to mxs-regulator > > > > I hope the change is okay. I implemented only is_enabled() to have at > > > least 1 > > > operation. > > > But it's not really necessary. > > > do we need enable / disable operation? > > > In the bootloader code enabling the DC-DC is critical. There is a known > > issue > > which falsely triggers the brownout detection. > > Why would the driver not provide these operations? I didn't implement this operation because the suggested workaround for the hardware issue isn't very nice (disable brownout detection during enabling DC-DC). I was afraid of the implementation. > > > > > I'm also not 100% clear what code the DCDCs and LDOs are > > > > sharing here... > > > > Actually only probing and the regulator info structure. > > > How can i improve that? > > If the devices aren't sharing code then they should be separate drivers. Okay. mxs-regulator-ldo.c mxs-regulator-dcdc.c What do you think of? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
