Hi Mark, > Stefan Wahren <stefan.wahren@xxxxxxxx> hat am 4. Mai 2015 um 22:34 > geschrieben: > > > Hi Mark, > > > Mark Brown <broonie@xxxxxxxxxx> hat am 4. Mai 2015 um 14:36 geschrieben: > > > > > > On Wed, Apr 29, 2015 at 10:32:26PM +0000, Stefan Wahren wrote: > > > > > +static struct regulator_ops mxs_dcdc_ops = { > > > + .is_enabled = regulator_is_enabled_regmap, > > > +}; > > > > Why do we have an is_enabled() operation but no enable or disable > > operation? > > i'm sorry, i forgot the following point in the changelog: > > - move dcdc handling from mxs_power to mxs-regulator > > I hope the change is okay. I implemented only is_enabled() to have at least 1 > operation. > But it's not really necessary. do we need enable / disable operation? In the bootloader code enabling the DC-DC is critical. There is a known issue which falsely triggers the brownout detection. > > > I'm also not 100% clear what code the DCDCs and LDOs are > > sharing here... > > Actually only probing and the regulator info structure. How can i improve that? > > Best regards > Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html