Re: [PATCH v3 1/2] dt-bindings: drm/bridge: Add no-hpd property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05/02/25 19:03, Dmitry Baryshkov wrote:
On Wed, Feb 05, 2025 at 12:52:52PM +0100, Krzysztof Kozlowski wrote:
On 05/02/2025 12:50, Harikrishna Shenoy wrote:
From: Rahul T R <r-ravikumar@xxxxxx>

The mhdp bridge can work without its HPD pin hooked up to the connector,
but the current bridge driver throws an error when hpd line is not
connected to the connector. For such cases, we need an indication for
no-hpd, using which we can bypass the hpd detection and instead use the
auxiliary channels connected to the DP connector to confirm the
connection.
So add no-hpd property to the bindings, to disable hpd when not
connected or unusable due to DP0-HPD not connected to correct HPD
pin on SOC like in case of J721S2.

Signed-off-by: Rahul T R <r-ravikumar@xxxxxx>

Why are you sending over and over the same? You already got feedback.
Then you send v2. You got the same feedback.

Now you send v3?

So the same feedback, but this time: NAK

Krzysztof's email forced me to take a look at the actual boards that you
are trying to enable. I couldn't stop by notice that the HPD signal
_is_ connected to a GPIO pin. Please stop hacking the bridge driver and
use the tools that are already provided to you: add the HPD pin to the
dp-controller device node. And then fix any possible issues coming from
the bridge driver not being able to handle HPD signals being delivered
by the DRM framework via the .hpd_notify() callback.

TL;DR: also a NAK from my side, add HPD gpio to dp-controller.

We tried implementing a interrupt based HPD functionality as HPD signal is connected to GPIO0_18 pin, we were able to get interrupt based HPD working however to route this signal to SoC we are loosing audio capability due to MUX conflict. Due to board level limitations to
route the signal to SoC, we will not be able to support interrupt
based HPD and polling seems a possible way without loosing on audio capability.

Link to schematics zip:
https://www.ti.com/tool/J721S2XSOMXEVM#design-files
File:sprr439b/PROC118E4_RP/PROC118E4(001)_SCH.pdf, Page 17, MUX1

Regards,
Hari





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux