On Tue, 11 Mar 2025 at 21:19, Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> wrote: > > > On 3/11/2025 9:05 PM, Dmitry Baryshkov wrote: > > On Tue, Mar 11, 2025 at 08:41:01PM +0530, Vikash Garodia wrote: > >> > >> On 3/11/2025 8:37 PM, Dmitry Baryshkov wrote: > >>> On Tue, Mar 11, 2025 at 05:33:53PM +0530, Vikash Garodia wrote: > >>>> Not all platforms has a collapsible mx, so use the more generic naming > >>>> of mx in the binding. > >>> > >>> I guess, it wasn't even tested... > >> Not sure what made you guess so, let me check why my binding checker did not > >> catch the bot reported warning. > > > > Obvious: you are changing the bindings in a non-backwards compatible > > way, but you are not changing the example in the same file (and > > obviously you are not changing the DTs), which means that this wasn't > > tested. > > > > Hint: you can use enum [mx, mxc] instead of const. That would make it > > backwards compatible. > Currently there are no user of this binding. Given that either of MX or MXC are > same connection to video hardware, just that one is collapsible, it would be > good to replace the existing element instead of enum. This obviously should go to the commit message. > > Regards, > Vikash > > > >> Regards, > >> Vikash > >>> > >>>> > >>>> Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> > >>>> --- > >>>> Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > >>>> index e424ea84c211f473a799481fd5463a16580187ed..440a0d7cdfe19a1ccedefc207d96b26eed5d6630 100644 > >>>> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > >>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml > >>>> @@ -28,7 +28,7 @@ properties: > >>>> items: > >>>> - const: venus > >>>> - const: vcodec0 > >>>> - - const: mxc > >>>> + - const: mx > >>>> - const: mmcx > >>>> > >>>> clocks: > >>>> > >>>> -- > >>>> 2.34.1 > >>>> > >>> > > -- With best wishes Dmitry
