On 28-02-25, 17:26, Robin Murphy wrote:
> +static u32 d350_get_residue(struct d350_chan *dch)
> +{
> + u32 res, xsize, xsizehi, hi_new;
> +
> + hi_new = readl_relaxed(dch->base + CH_XSIZEHI);
> + do {
> + xsizehi = hi_new;
> + xsize = readl_relaxed(dch->base + CH_XSIZE);
> + hi_new = readl_relaxed(dch->base + CH_XSIZEHI);
> + } while (xsizehi != hi_new);
This can go forever, lets have some limits to this loop please
> +static int d350_alloc_chan_resources(struct dma_chan *chan)
> +{
> + struct d350_chan *dch = to_d350_chan(chan);
> + int ret = request_irq(dch->irq, d350_irq, IRQF_SHARED,
> + dev_name(&dch->vc.chan.dev->device), dch);
This is interesting, any reason why the irq is allocated here? Would it
be not better to do that in probe...
--
~Vinod
