Hi Chukun, On 2025-03-07 13:00, Chukun Pan wrote: > Add pwm nodes for RK3528. The PWM core on RK3528 is the same as > RK3328, but the driver does not support interrupts yet. > > Signed-off-by: Chukun Pan <amadeus@xxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3528.dtsi | 88 ++++++++++++++++++++++++ > 1 file changed, 88 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi > index b1713ed4d7e2..ab1ac3273611 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi > @@ -264,6 +264,94 @@ uart7: serial@ffa28000 { > status = "disabled"; > }; > > + pwm0: pwm@ffa90000 { > + compatible = "rockchip,rk3528-pwm", "rockchip,rk3328-pwm"; nitpick: This could be split in two lines to match similar >80 chars long lines in this file: compatible = "rockchip,rk3528-pwm", "rockchip,rk3328-pwm"; And similar for the remaining pwmX. Regards, Jonas > + reg = <0x0 0xffa90000 0x0 0x10>; > + clocks = <&cru CLK_PWM0>, <&cru PCLK_PWM0>; > + clock-names = "pwm", "pclk"; > + pinctrl-0 = <&pwm0m0_pins>; > + pinctrl-names = "active"; > + #pwm-cells = <3>; > + status = "disabled"; > + }; > + [snip]