Hi Yao Zi, On 2025-03-09 08:06, Yao Zi wrote: > Describe I2C controllers shipped by RK3528 in devicetree. > > Signed-off-by: Yao Zi <ziyao@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/rk3528.dtsi | 104 +++++++++++++++++++++++ > 1 file changed, 104 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi > index 04ca2e2b3e9b..860b6057e5c2 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi > @@ -19,6 +19,14 @@ / { > #size-cells = <2>; > > aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; nitpick: These should be ordered after the gpioX aliases. Regards, Jonas > gpio0 = &gpio0; > gpio1 = &gpio1; > gpio2 = &gpio2; [snip]