On 25-03-07 23:03:07, Aleksandrs Vinarskis wrote: > > > On 2/20/25 18:42, Abel Vesa wrote: > > Since the driver and dt-bindings have been alread merged, it has been > > agreed offline that there is no point of holding on to these DT patches > > even though there are some issues with plug/unplug during suspend in > > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > > meanwhile. Merging these means that even though this will provide external DP > > and USB orientation, plug/unplug during suspend will give some splats > > and render both the USB orientation and DP broken. But then, other > > X Elite boards already have these nodes described, so lets bring the crd > > and t14s to the same level. > > > > These patches are just a resend of the ones found in v5 and dropped in the v6 > > patchset of the driver and dt-bindings. > > > > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@xxxxxxxxxx/ > > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > > If you will be respinning, could you please add link-frequencies to > enable HBR3 speeds, similarly to [1]? Alternatively, I can also send > fixups once this series lands. It's already re-spun here: https://lore.kernel.org/all/20250304-x1e80100-dts-crd-t14s-enable-typec-retimers-v6-0-e5a49fae4e94@xxxxxxxxxx/ Waiting to be merged. Lets make the HBR3 enablement a separate patchset as I'm not able to test it in time, if we want external DP to be part of 6.15. > > [1] > https://lore.kernel.org/all/20250226231436.16138-1-alex.vinarskis@xxxxxxxxx/ > > Thanks, > Alex > > > --- > > Abel Vesa (4): > > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > > > .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- > > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- > > 2 files changed, 785 insertions(+), 10 deletions(-) > > --- > > base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24 > > change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d > > > > Best regards, >