On 07/03/2025 13:47, Darren.Ye wrote:
> From: Darren Ye <darren.ye@xxxxxxxxxxxx>
>
> Export register read and write interface, add sample reate interface, and
> update the mtk_memif_set_channel interface for the mt8196 platform.
>
> Signed-off-by: Darren Ye <darren.ye@xxxxxxxxxxxx>
> ---
> sound/soc/mediatek/common/mtk-afe-fe-dai.c | 30 ++++++++++++++--------
> sound/soc/mediatek/common/mtk-afe-fe-dai.h | 6 +++++
> sound/soc/mediatek/common/mtk-base-afe.h | 13 ++++++++++
> 3 files changed, 38 insertions(+), 11 deletions(-)
>
> diff --git a/sound/soc/mediatek/common/mtk-afe-fe-dai.c b/sound/soc/mediatek/common/mtk-afe-fe-dai.c
> index 3809068f5620..c36dae520f04 100644
> --- a/sound/soc/mediatek/common/mtk-afe-fe-dai.c
> +++ b/sound/soc/mediatek/common/mtk-afe-fe-dai.c
> @@ -18,7 +18,7 @@
>
> #define AFE_BASE_END_OFFSET 8
>
> -static int mtk_regmap_update_bits(struct regmap *map, int reg,
> +int mtk_regmap_update_bits(struct regmap *map, int reg,
You need kerneldoc for all exported functions.
> unsigned int mask,
> unsigned int val, int shift)
> {
> @@ -26,13 +26,16 @@ static int mtk_regmap_update_bits(struct regmap *map, int reg,
> return 0;
> return regmap_update_bits(map, reg, mask << shift, val << shift);
> }
> +EXPORT_SYMBOL(mtk_regmap_update_bits);
GPL
> +
> +int mtk_regmap_write(struct regmap *map, int reg, unsigned int val)
>
Why blank line?
> -static int mtk_regmap_write(struct regmap *map, int reg, unsigned int val)
Missing kerneldoc
> {
> if (reg < 0)
> return 0;
> return regmap_write(map, reg, val);
> }
> +EXPORT_SYMBOL(mtk_regmap_write);
GPL
Best regards,
Krzysztof
