Re: [PATCH v3 5/6] ASoC: meson: s4: Add s4 tocodec driver

Jiebing Chen <jiebing.chen@xxxxxxxxxxx> · Fri, 7 Mar 2025 10:48:10 +0800

在 2025/3/6 23:58, Jerome Brunet 写道:
[ EXTERNAL EMAIL ]

On Fri 28 Feb 2025 at 16:04, jiebing chen via B4 Relay <devnull+jiebing.chen.amlogic.com@xxxxxxxxxx> wrote:

From: jiebing chen <jiebing.chen@xxxxxxxxxxx>

S4 tocodec support 8 lane to input, It need to enable
bclk and mclk control bit when work

Signed-off-by: jiebing chen <jiebing.chen@xxxxxxxxxxx>
---
  sound/soc/meson/g12a-toacodec.c | 51 +++++++++++++++++++++++++++++++++++++++++
  1 file changed, 51 insertions(+)

diff --git a/sound/soc/meson/g12a-toacodec.c b/sound/soc/meson/g12a-toacodec.c
index 531bb8707a3ec4c47814d6a0676d5c62c705da75..41eef9980059285275f0189a06469fc694775955 100644
--- a/sound/soc/meson/g12a-toacodec.c
+++ b/sound/soc/meson/g12a-toacodec.c
@@ -41,6 +41,9 @@
  #define  CTRL0_BCLK_SEL_LSB          4
  #define  CTRL0_MCLK_SEL                      GENMASK(2, 0)

+#define CTRL0_BCLK_ENABLE_SHIFT              30
+#define CTRL0_MCLK_ENABLE_SHIFT              29
+
  #define TOACODEC_OUT_CHMAX           2

  struct g12a_toacodec {
@@ -129,6 +132,10 @@ static const struct snd_kcontrol_new g12a_toacodec_out_enable =
       SOC_DAPM_SINGLE_AUTODISABLE("Switch", TOACODEC_CTRL0,
                                   CTRL0_ENABLE_SHIFT, 1, 0);

+static const struct snd_kcontrol_new s4_toacodec_clk_enable =
+     SOC_DAPM_DOUBLE("Switch", TOACODEC_CTRL0,
+                     CTRL0_BCLK_ENABLE_SHIFT, CTRL0_MCLK_ENABLE_SHIFT, 1, 0);
+
  static const struct snd_soc_dapm_widget g12a_toacodec_widgets[] = {
       SND_SOC_DAPM_MUX("SRC", SND_SOC_NOPM, 0, 0,
                        &g12a_toacodec_mux),
@@ -143,6 +150,15 @@ static const struct snd_soc_dapm_widget sm1_toacodec_widgets[] = {
                           &g12a_toacodec_out_enable),
  };

+static const struct snd_soc_dapm_widget s4_toacodec_widgets[] = {
+     SND_SOC_DAPM_MUX("SRC", SND_SOC_NOPM, 0, 0,
+                      &sm1_toacodec_mux),
+     SND_SOC_DAPM_SWITCH("OUT EN", SND_SOC_NOPM, 0, 0,
+                         &g12a_toacodec_out_enable),
+     SND_SOC_DAPM_SWITCH("CLK EN", SND_SOC_NOPM, 0, 0,
+                         &s4_toacodec_clk_enable),
I don't see a reason for the user to control that.

A user controls if the component is enable or not, and possibly select
the lane ... but that's it

You could have to flipped automatically which dapm when the component is
powered, that would make a lot more sense.

Hi,Jerome

Thank you for your suggestion. Can we design it as a supply widget for 
tocodec bclk and mclk control?

when dapm poweron, and supply widget power on, Users do not have to 
operate additional Kcontrols


+};
+
  static int g12a_toacodec_input_hw_params(struct snd_pcm_substream *substream,
                                        struct snd_pcm_hw_params *params,
                                        struct snd_soc_dai *dai)
@@ -228,6 +244,15 @@ static const struct snd_soc_dapm_route g12a_toacodec_routes[] = {
       { "OUT Capture", NULL, "OUT EN" },
  };

+static const struct snd_soc_dapm_route s4_toacodec_routes[] = {
+     { "SRC", "I2S A", "IN A Playback" },
+     { "SRC", "I2S B", "IN B Playback" },
+     { "SRC", "I2S C", "IN C Playback" },
+     { "OUT EN", "Switch", "SRC" },
+     { "CLK EN", "Switch", "OUT EN" },
+     { "OUT Capture", NULL, "CLK EN" },
+};
+
  static const struct snd_kcontrol_new g12a_toacodec_controls[] = {
       SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL, 3, 0),
  };
@@ -236,6 +261,10 @@ static const struct snd_kcontrol_new sm1_toacodec_controls[] = {
       SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 3, 0),
  };

+static const struct snd_kcontrol_new s4_toacodec_controls[] = {
+     SOC_SINGLE("Lane Select", TOACODEC_CTRL0, CTRL0_LANE_SEL_SM1, 7, 0),
+};
+
  static const struct snd_soc_component_driver g12a_toacodec_component_drv = {
       .probe                  = g12a_toacodec_component_probe,
       .controls               = g12a_toacodec_controls,
@@ -258,6 +287,17 @@ static const struct snd_soc_component_driver sm1_toacodec_component_drv = {
       .endianness             = 1,
  };

+static const struct snd_soc_component_driver s4_toacodec_component_drv = {
+     .probe                  = sm1_toacodec_component_probe,
+     .controls               = s4_toacodec_controls,
+     .num_controls           = ARRAY_SIZE(s4_toacodec_controls),
+     .dapm_widgets           = s4_toacodec_widgets,
+     .num_dapm_widgets       = ARRAY_SIZE(s4_toacodec_widgets),
+     .dapm_routes            = s4_toacodec_routes,
+     .num_dapm_routes        = ARRAY_SIZE(s4_toacodec_routes),
+     .endianness             = 1,
+};
+
  static const struct regmap_config g12a_toacodec_regmap_cfg = {
       .reg_bits       = 32,
       .val_bits       = 32,
@@ -278,6 +318,13 @@ static const struct g12a_toacodec_match_data sm1_toacodec_match_data = {
       .field_bclk_sel = REG_FIELD(TOACODEC_CTRL0, 4, 6),
  };

+static const struct g12a_toacodec_match_data s4_toacodec_match_data = {
+     .component_drv  = &s4_toacodec_component_drv,
+     .field_dat_sel  = REG_FIELD(TOACODEC_CTRL0, 19, 20),
+     .field_lrclk_sel = REG_FIELD(TOACODEC_CTRL0, 12, 14),
+     .field_bclk_sel = REG_FIELD(TOACODEC_CTRL0, 4, 6),
+};
+
  static const struct of_device_id g12a_toacodec_of_match[] = {
       {
               .compatible = "amlogic,g12a-toacodec",
@@ -287,6 +334,10 @@ static const struct of_device_id g12a_toacodec_of_match[] = {
               .compatible = "amlogic,sm1-toacodec",
               .data = &sm1_toacodec_match_data,
       },
+     {
+             .compatible = "amlogic,s4-toacodec",
+             .data = &s4_toacodec_match_data,
+     },
       {}
  };
  MODULE_DEVICE_TABLE(of, g12a_toacodec_of_match);
--
Jerome







