Hi Andrew,
On 2025-03-06 23:46, Andrew Lunn wrote:
> On Thu, Mar 06, 2025 at 10:13:56PM +0000, Jonas Karlman wrote:
>> Rockchip RK3528 has two Ethernet controllers based on Synopsys DWC
>> Ethernet QoS IP.
>>
>> Add device tree nodes for the two Ethernet controllers in RK3528.
>>
>> Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
>> ---
>> gmac0 is missing the integrated-phy and has not been tested bacause I do
>> not have any board that use this Ethernet controller.
>
> What do you know about the integrated PHY? Does it use one of the
> standard phy-modes? RMII? Does the datasheet indicate what address it
> uses on the MDIO bus? If you know these two bits of information, you
> can probably add it.
The SoC datasheet lists following:
MAC 10/100/1000 Ethernet Controller (gmac1)
- Support 10/100/1000 Mbps data transfer rates with the RGMII interfaces
- Support 10/100 Mbps data transfer rates with the RMII interfaces
- Support both full-duplex and half-duplex operation
- Supports IEEE 802.1Q VLAN tag detection for reception frames
- Support detection of LAN wake-up frames and AMD Magic Packet frames
- Support checking IPv4 header checksum and TCP, UDP, or ICMP checksum
encapsulated in IPv4 or IPv6 datagram
- Support for TCP Segmentation Offload (TSO) and UDP Fragmentation
Offload (UFO)
MAC 10/100M Ethernet controller and MAC PHY (gmac0)
- Support one Ethernet controllers
- Support 10/100-Mbps data transfer rates with the RMII interfaces
- Support both full-duplex and half-duplex operation
and vendor kernel use following DT node:
phy-mode = "rmii";
clock_in_out = "input";
phy-handle = <&rmii0_phy>;
mdio0: mdio {
compatible = "snps,dwmac-mdio";
#address-cells = <0x1>;
#size-cells = <0x0>;
rmii0_phy: ethernet-phy@2 {
compatible = "ethernet-phy-id0044.1400", "ethernet-phy-ieee802.3-c22";
reg = <2>;
clocks = <&cru CLK_MACPHY>;
resets = <&cru SRST_MACPHY>;
phy-is-integrated;
pinctrl-names = "default";
pinctrl-0 = <&fephym0_led_link &fephym0_led_spd>;
};
};
I could possible add something like that to the device tree, or I could
drop the entire gmac0 node and instead have it added in a future series.
Regards,
Jonas
>
> Andrew
