On Thu, Mar 06, 2025 at 09:09:45PM +0000, Jonas Karlman wrote: > All Rockchip GMAC variants require writing to GRF to configure e.g. > interface mode and MAC rx/tx delay. > > Change binding to require rockchip,grf and rockchip,php-grf to reflect > that GRF (and PHP-GRF for RK3576/RK3588) control part of GMAC. It is pretty unusual to change the binding such that something optional becomes mandatory. I would expect a bit more of a comment explaining why this does not cause backwards compatibility issues. Have all the .dtsi files always had these properties? Andrew --- pw-bot: cr