All Rockchip GMAC variants require writing to GRF to configure e.g. interface mode and MAC rx/tx delay. Change binding to require rockchip,grf and rockchip,php-grf to reflect that GRF (and PHP-GRF for RK3576/RK3588) control part of GMAC. Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx> --- --- .../devicetree/bindings/net/rockchip-dwmac.yaml | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index f8a576611d6c..05a5605f1b51 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -32,9 +32,6 @@ select: required: - compatible -allOf: - - $ref: snps,dwmac.yaml# - properties: compatible: oneOf: @@ -114,6 +111,20 @@ required: - compatible - clocks - clock-names + - rockchip,grf + +allOf: + - $ref: snps,dwmac.yaml# + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3576-gmac + - rockchip,rk3588-gmac + then: + required: + - rockchip,php-grf unevaluatedProperties: false -- 2.48.1