On 05/03/2025 08:10, Zhang Yi wrote: > >>> + >>> + prefix_name: >> >> No underscores in node names, missing vendor prefix... but more >> important: I don't understand the need for this property. Description copies property name so it is not useful. And these comments as well. >> >> Drop. You maybe wanted dai prefix, but this is already in dai-common. > > I will update description at v4 PATCH > >>> + everest,dmic-enabled: >>> + $ref: /schemas/types.yaml#/definitions/flag >>> + description: >>> + The property is a choice between PDM and AMIC >>> + >> >> No supplies? > > I will drop the property I did not comment about dmic, but meant missing power supplies, which usually are placed here. > >>> +required: >>> + - compatible >>> + - reg >>> + - "#sound-dai-cells" Best regards, Krzysztof
