> > +
> > +properties:
> > + compatible:
> > + const: everest,es8389
>
> Device is really different than es8388?
yes, it's different from es8388
> > + "#sound-dai-cells":
> > + const: 0
> > +
> > + everest,adc-slot:
> > + $ref: /schemas/types.yaml#/definitions/uint8
> > + description: |
> > + This property is used to set the slots of recording data when multiple
> > + codecs are connected in PTDM mode.
> > + please set this property to default if you are setting STDM mode.
> > + minimum: 0x00
>
> Drop, unsigned does not allow -1.
>
> > + maximum: 0x07
> > + default: 0x00
>
> All of these should be rather decimal.
I will try to fix the error
> > +
> > + prefix_name:
>
> No underscores in node names, missing vendor prefix... but more
> important: I don't understand the need for this property. Description copies property name so it is not useful.
>
> Drop. You maybe wanted dai prefix, but this is already in dai-common.
I will update description at v4 PATCH
> > + everest,dmic-enabled:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description:
> > + The property is a choice between PDM and AMIC
> > +
>
> No supplies?
I will drop the property
> > +required:
> > + - compatible
> > + - reg
> > + - "#sound-dai-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + i2c{
>
> Missing space.
>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + es8389: es8389@10 {
>
> Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> > + compatible = "everest,es8389";
> > + reg = <0x10>;
> > + everest,adc-slot = [00];
>
> Please open other bindings or DTS and take a look how single number is encoded. In general, please rather base your work on latest bindings and DTS accepted by reviewers and use them as learning/template to avoid common mistakes. At least two comments in this review could be avoided if you did this.
>
> > + everest,dac-slot = [00];
> > + prefix_name = "es8389_0";
>
> Drop
I will try to fix it
