On 04/03/2025 15:40, Jacky Bai wrote: > Hi Rob, > >> Subject: Re: [PATCH v2 1/4] dt-bindings: dma: fsl-edma: add >> interrupts-extended property >> >> On Tue, Mar 04, 2025 at 05:31:24PM +0800, Jacky Bai wrote: >>> Add interrupts-extended property for edma that has multiple interrupt >>> controllers used. >> >> Did you try using interrupts-extended? No. Because either is supported by the >> tools already. >> > > We need to use interrupts-extended property for i.MX94 because for the edma's > interrupts, some are connected to irqsteer interrupt controller and some are connected > to the GIC. make dtbs_check report error, so I add this dt binding changes. > > Sorry, Which tools are you referring? Linux, dtschema, everything. > >>> >>> Signed-off-by: Jacky Bai <ping.bai@xxxxxxx> >>> --- >>> - v2 changes: >>> - newly added entry >>> --- >>> Documentation/devicetree/bindings/dma/fsl,edma.yaml | 11 >> ++++++++++- >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> b/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> index d54140f18d34..549afb8611a9 100644 >>> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml >>> @@ -38,6 +38,10 @@ properties: >>> minItems: 1 >>> maxItems: 64 >>> >>> + interrupts-extended: >>> + minItems: 1 >>> + maxItems: 65 >> >> Doesn't match the size for interrupt-names: >> > > The interrupt-names are only true for vf610, maxItems is > enough for such case. do we still need to update it? They always go in sync. Anyway, you did not get the point of Rob's comments: this patch is neither needed nor correct. Just drop it and test again your DTS. Best regards, Krzysztof
