Hi Bjorn, On 6 May 2015 at 00:16, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Fri, Apr 10, 2015 at 11:12:46AM +0200, Gabriel FERNANDEZ wrote: >> sti pcie is built around a Synopsis Designware PCIe IP. >> >> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxx> >> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxx> > >> +/* ST PCIe driver does not allow module unload */ > > Is there something that prevents module unload, or is it just untested? > Yes we haven't tested >> +static int __init pcie_init(void) >> +{ >> + return platform_driver_probe(&st_pcie_driver, st_pcie_probe); >> +} >> +device_initcall(pcie_init); > > Can you use module_platform_driver_probe() or module_init() here? > Yes we can use module_init() here. By the way if figure out i removed __init attribute on st_pcie_probe() in previous version to follow Arnd's remark. But st_pcie_probe calls hook_fault_code() that has __init attribute. So I think we need to keep __init for probe routine ? Also, we have to restrict bind/unbind with "suppress_bind_attrs" in platform_driver structure. This is the main reason to not allow module unload/reload. If you are ok i will send a v4 ? BR Gabriel >> +MODULE_AUTHOR("Fabrice Gasnier <fabrice.gasnier@xxxxxx>"); >> +MODULE_DESCRIPTION("PCI express Driver for ST SoCs"); >> +MODULE_LICENSE("GPL v2"); >> -- >> 1.9.1 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html