On Sat, May 02, 2015 at 05:46:22PM +0200, Paul Kocialkowski wrote: > Le mardi 28 avril 2015 à 17:09 +0100, Russell King - ARM Linux a écrit : > > On Mon, Apr 27, 2015 at 04:42:27PM +0200, Paul Kocialkowski wrote: > > > Well, of_property_read_string is only defined when CONFIG_OF is set > > > (base.c is always built in drivers/of but the directory is only included > > > when CONFIG_OF is set). > > > > > > Of course, on ARM, we now expect that it is the case, but it seems like > > > good practice to check for it, since it could theoretically be disabled. > > > > That is _not_ "is the case" - there are a number of non-OF platforms... > > including some which will probably never be converted. > > Right, so I think v4 should be fine too, given the empty functions in > case CONFIG_OF is not set. Yes, can you please put them in my patch system so we can get this applied? Rob - does your ack apply to the v4 patch? Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html