Hi Rob, Thank you for the review. On Mon, Mar 3, 2025 at 3:26 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Sun, Mar 02, 2025 at 06:18:06PM +0000, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Increase the `maxItems` value for the `interrupts` and `interrupt-names` > > properties to accommodate the Renesas RZ/V2H(P) SoC, which features the > > `snps,dwmac-5.20` IP with 11 interrupts. > > > > Also add `additionalItems: true` to allow specifying extra interrupts > > beyond the predefined ones. Update the `interrupt-names` property to > > allow specifying extra `interrupt-names`. > > > > Also refactor the optional `interrupt-names` property by consolidating > > repeated enums into a single enum list. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > index 91e75eb3f329..85d499bd49b5 100644 > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > @@ -110,6 +110,8 @@ properties: > > > > interrupts: > > minItems: 1 > > + maxItems: 11 > > + additionalItems: true > > This just increased the number if interrupts for anyone that allowed 4 > interrupts. Rockchip and Intel are 2 though it is not clear if they > support more than 1. So maybe not a new problem, but you are making it > worse. Any of the ones in the 'select' in this file are affected as > well. > How do you want me to handle this case: 1] Update vendors binding 2] Duplicate snps,dwmac.yaml in vendors binding. Cheers, Prabhakar
