пн, 3 бер. 2025 р. о 10:18 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише: > > On 03/03/2025 09:11, Svyatoslav Ryhel wrote: > > пн, 3 бер. 2025 р. о 09:54 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише: > >> > >> On 27/02/2025 11:55, Svyatoslav Ryhel wrote: > >>>>> + > >> > >> Please kindly trim the replies from unnecessary context. It makes it > >> much easier to find new content. > >> > >>>>> + maxim,usb-in-current-limit-microamp: > >>>>> + description: > >>>>> + USB Input current limit > >>>>> + minimum: 100000 > >>>>> + default: 500000 > >>>>> + maximum: 1500000 > >>>>> + > >>>>> + maxim,ac-in-current-limit-microamp: > >>>>> + description: > >>>>> + AC Input current limit > >>>>> + minimum: 100000 > >>>>> + default: 500000 > >>>>> + maximum: 1500000 > >>>> > >>>> Half of these properties as well are not suitable and duplicate existing > >>>> sysfs interface. > >>>> > >>> > >>> All these properties allow configure the charger to suit the device on > >>> which it is used. None of them are required but are a nice addition. > >>> Why you are denying me an ability to fully utilize hardware I have and > >>> tune it to the device? All those values represent hardware registers > >>> which can be customized for the device, not for the end user to mess > >>> with. > >> > >> Because you put user-space choice or OS policy into the DT and DT is not > >> for that. > >> > > > > Those are NOT user-space choice or OS policy those are vendor > > configuration for a specific device and are NOT and NEVER were exposed > > Then look at existing devices. We had these discussions in the past and > these are usually exposed to user-space. > Provide an example, where there is same or similar configuration. > > to user configurations EVER. User messing with those may lead to > > device breaking. > > > >>> > >>>> And for remaining, still no battery. > >>>> > >>> > >>> reference to power-supply IS included, hence the battery option is > >>> there as well. > >> > >> I don't see it being used at all and you explicitly duplicated > >> properties which means that reference is redundant and should be dropped > >> with such binding. So how did you solve my request to add reference > >> which then you make redundant? Add reference and use it. > >> > > > > Which properties I have duplicated? > > All the current limits. > Those are blank works, show me an example of such duplication. > > > >> Best regards, > >> Krzysztof > > > Best regards, > Krzysztof