чт, 27 лют. 2025 р. о 12:45 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише: > > On Wed, Feb 26, 2025 at 11:36:59AM +0200, Svyatoslav Ryhel wrote: > > + maxim,fcharge-current-limit-microamp: > > + description: > > + Fast-Charge current limit > > + minimum: 250000 > > + default: 500000 > > + maximum: 1550000 > > + > > + maxim,fcharge-timer-hours: > > + description: > > + Fast-Charge timer in hours. Setting this value 3 and lower or 11 and higher > > + will disable Fast-Charge timer. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + default: 5 > > You still did not answer why this is board specific. This was rejected > in the past because of that reason and nothing here changed. Nothing > will change without detailed explanation, so use other interfaces if you > need user-space to configure it (see other drivers, e.g. maxim) > > > + > > + maxim,fcharge-rst-threshold-high: > > + description: > > + Set Fast-Charge reset threshold to -100 mV > > + type: boolean > > + > > + maxim,in-current-limit-microamp: > > + description: > > + Input current limit > > + minimum: 100000 > > + default: 500000 > > + maximum: 1500000 > > + > > + maxim,topoff-timer-minutes: > > + description: > > + Top-Off timer minutes > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 10, 20, 30, 40, 50, 60, 70] > > + default: 30 > > Same. > > > + > > + maxim,topoff-current-threshold-microamp: > > + description: > > + Top-Off current threshold > > + enum: [50000, 100000, 150000, 200000] > > + default: 50000 > > + > > + maxim,fcharge-usb-current-limit-microamp: > > + description: > > + Fast-Charge USB current limit > > + minimum: 100000 > > + default: 500000 > > + maximum: 1500000 > > + > > + maxim,fcharge-ac-current-limit-microamp: > > + description: > > + Fast-Charge AC current limit > > + minimum: 100000 > > + default: 500000 > > + maximum: 1500000 > > + > > + maxim,usb-in-current-limit-microamp: > > + description: > > + USB Input current limit > > + minimum: 100000 > > + default: 500000 > > + maximum: 1500000 > > + > > + maxim,ac-in-current-limit-microamp: > > + description: > > + AC Input current limit > > + minimum: 100000 > > + default: 500000 > > + maximum: 1500000 > > Half of these properties as well are not suitable and duplicate existing > sysfs interface. > All these properties allow configure the charger to suit the device on which it is used. None of them are required but are a nice addition. Why you are denying me an ability to fully utilize hardware I have and tune it to the device? All those values represent hardware registers which can be customized for the device, not for the end user to mess with. > And for remaining, still no battery. > reference to power-supply IS included, hence the battery option is there as well. > Best regards, > Krzysztof >