On 25/02/28 06:22PM, Conor Dooley wrote: > On Fri, Feb 28, 2025 at 08:40:23PM +0800, Zixian Zeng wrote: > > Add spi controllers for SG2042. > > > > SG2042 uses the upstreamed Synopsys DW SPI IP. > > > > Signed-off-by: Zixian Zeng <sycamoremoon376@xxxxxxxxx> > > --- > > For this spi controller patch, only bindings are included. > > ^^^ you've not actually included any bindings in this patch, copy-paste > mistake? > My bad, I was confused about what’s the “binding” meaning. I will remove this description in next revision. > > This is tested on milkv-pioneer board. Using driver/spi/spidev.c > > for creating /dev/spidevX.Y and tools/spi/spidev_test for testing > > functionality. > > --- > > Changes in v2: > > - rebase v1 to sophgo/master(github.com/sophgo/linux.git). > > - order properties in device node. > > - remove unevaluated properties `clock-frequency`. > > - set default status to disable. > > - Link to v1: https://lore.kernel.org/r/20250228-sfg-spi-v1-1-b989aed94911@xxxxxxxxx > > --- > > .../riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts | 8 +++++++ > > arch/riscv/boot/dts/sophgo/sg2042.dtsi | 28 ++++++++++++++++++++++ > > 2 files changed, 36 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > > index be596d01ff8d33bcdbe431d9731a55ee190ad5b3..c43a807af2f827b5267afe5e4fdf6e9e857dfa20 100644 > > --- a/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > > +++ b/arch/riscv/boot/dts/sophgo/sg2042-milkv-pioneer.dts > > @@ -72,6 +72,14 @@ &uart0 { > > status = "okay"; > > }; > > > > +&spi0 { > > + status = "okay"; > > +}; > > + > > +&spi1 { > > + status = "okay"; > > +}; > > + > > / { > > thermal-zones { > > soc-thermal { > > diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi > > index e62ac51ac55abd922b5ef796ba8c2196383850c4..500645147b1f8ed0a08ad3cafb38ea79cf57d737 100644 > > --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi > > +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi > > @@ -545,5 +545,33 @@ sd: mmc@704002b000 { > > "timer"; > > status = "disabled"; > > }; > > + > > + spi0: spi@7040004000 { > > + compatible = "snps,dw-apb-ssi"; > > I thought were were dropping the use of "snps,dw-abp-ssi" in isolation, > and starting to require soc-specific compatibles now. > That’s better, I will do it in next revision. BTW, <https://lore.kernel.org/linux-riscv/20240703-garbage-explicit-bd95f8deb716@wendy> has similar situation, those patches only create binding but not implement the compatible property of "thead,th1520-spi” in driver. When kernel matching, it will find out there’s no compatible of "thead,th1520-spi” so fallback to "snps,dw-apb-ssi” May I take you a few minutes for reason behind it? My understanding is that using soc-specific compatible is better for future maintaining, If the device actually comes with some unknown quirks not present in the generic IP. And all we need to do for fixing is implementing the soc-specific compatible property. > Rob, Krzysztof? > Best regards, Zixian Zeng
