On 27/02/2025 20:25, Wilson Ding wrote:
> Add the reset controller node as a sub-node to the system controller
> node.
>
> Signed-off-by: Wilson Ding <dingwei@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 161beec0b6b0..c27058d1534e 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -226,6 +226,8 @@ CP11X_LABEL(rtc): rtc@284000 {
> CP11X_LABEL(syscon0): system-controller@440000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x440000 0x2000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
>
> CP11X_LABEL(clk): clock {
Wait, no unit address here.
> compatible = "marvell,cp110-clock";
> @@ -273,6 +275,12 @@ CP11X_LABEL(gpio2): gpio@140 {
> <&CP11X_LABEL(clk) 1 17>;
> status = "disabled";
> };
> +
> + CP11X_LABEL(swrst): reset-controller@268 {
So why here it appeared? This is wrong and not even necessary. Entire
child should be folded into parent, so finally you will fix the
incomplete parent compatible.
Best regards,
Krzysztof
