On 2025/2/4 16:44, Inochi Amaoto wrote: [......]
diff --git a/drivers/clk/sophgo/clk-sg2044.c b/drivers/clk/sophgo/clk-sg2044.c new file mode 100644 index 000000000000..7185c11ea2a5 --- /dev/null +++ b/drivers/clk/sophgo/clk-sg2044.c @@ -0,0 +1,2271 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Sophgo SG2042 clock controller Driver + * + * Copyright (C) 2024 Inochi Amaoto <inochiama@xxxxxxxxxxx>
I'm afraid you may need to use your new gmail emailbox address. [......]
+static int sg2044_clk_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct sg2044_clk_ctrl *ctrl; + const struct sg2044_clk_desc_data *desc; + void __iomem *reg; + struct regmap *regmap; + u32 num_clks; + + reg = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(reg)) + return PTR_ERR(reg); + + regmap = syscon_regmap_lookup_by_compatible("sophgo,sg2044-top-syscon");
What's this? Do you miss some descritpion about dependency (in cover-letter?)
Others LGTM. Reviewed-by: Chen Wang <unicorn_wang@xxxxxxxxxxx> Regards, Chen [......]