On 25/02/2025 03:20, Ryan Chen wrote: >>>>> + >>>>> + return devm_add_action_or_reset(clk_dev, >>>>> +aspeed_reset_unregister_adev, adev); } >>>>> +EXPORT_SYMBOL_GPL(aspeed_reset_controller_register); >>>> >>>> No, you cannot export functions without users. There is no single >>>> user of this, so this is not justified at all. >>> My mistake, I missed patch #3 which uses it. >>> >>> I don't get why do you need to export this in the first place, instead >>> of putting it in the clock driver, as usually expected. Handling child >>> creation is logically the task of the device having children, the >>> parent. Not the child. >> >> Also, consider basing this on top of: >> >> https://lore.kernel.org/all/20250218-aux-device-create-helper-v4-0-c3d7dfdea >> 2e6@xxxxxxxxxxxx/ > > Hello, Base on this series, I will use adev = devm_auxiliary_device_create instead addev_alloc, adev_releas. > But it still have EXPORT_SYMBOL_GPL(aspeed_reset_controller_register); > Am I right? Why? It looks like you skipped entirely my message. It is the same over and over - respond to people comments... Best regards, Krzysztof
