Hi Geert, > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 24 February 2025 09:05 > Subject: Re: [PATCH v2 01/18] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/V2H(P) SoC > > On Mon, 24 Feb 2025 at 10:00, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Sun, 23 Feb 2025 at 19:09, Laurent Pinchart > > <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > > On Fri, Feb 21, 2025 at 04:55:15PM +0100, Tommaso Merciai wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > > > The MIPI CSI-2 block on the Renesas RZ/V2H(P) SoC is similar to > > > > the one found on the Renesas RZ/G2L SoC, with the following differences: > > > > - A different D-PHY > > > > - Additional registers for the MIPI CSI-2 link > > > > - Only two clocks > > > > > > > > Add a new compatible string, `renesas,r9a09g057-csi2`, for the > > > > RZ/V2H(P) SoC. > > > > > > > > Signed-off-by: Lad Prabhakar > > > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx> > > > > > > --- > > > > a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml > > > > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.y > > > > +++ aml > > > > > > @@ -48,7 +58,7 @@ properties: > > > > resets: > > > > items: > > > > - description: CRU_PRESETN reset terminal > > > > - - description: CRU_CMN_RSTB reset terminal > > > > + - description: CRU_CMN_RSTB reset terminal or D-PHY reset > > > > > > I'd mention which SoCs these apply to: > > > > > > - description: > > > CRU_CMN_RSTB reset terminal (all but RZ/V2H) or D-PHY > > > reset (RZ/V2H) > > > > Note that RZ/G3E uses the same naming, so be prepared for more churn... > > > > However, I am confused... > > > > 1. According to Section 35.3.1 "Starting Reception for the MIPI CSI-2 > > Input" (RZ/G2L Rev. 1.45) CPG_RST_CRU.CRU_CMN_RSTB _is_ the > > D-PHY reset. > > This is still valid. > > > 2. The CRU has three (not two) resets on all: > > - CRU_PRESETN, > > - CRU_ARESETN, > > - CRU_CMN_RSTB (RZ/G2L, RZ/V2L, and RZ/G2UL) or > > CRU_S_RESETN (RZ/V2H and RZ/G3E). > > Sorry, I missed this binding is about the CSI-2, not the CRU. > So the third interrupt is really about the CSI-2 PHY. You mean typo, interrupt->reset?? Cheers, Biju
