On Thu, Feb 20, 2025 at 05:35:20PM -0600, Bjorn Helgaas wrote: > On Thu, Jan 16, 2025 at 07:39:13PM +0530, Manivannan Sadhasivam via B4 Relay wrote: > > From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > > > The pwrctrl core will rescan the bus once the device is powered on. So > > there is no need to continue scanning for the device further. > > > -/* > > - * Create pwrctrl device (if required) for the PCI device to handle the power > > - * state. > > - */ > > -static void pci_pwrctrl_create_device(struct pci_bus *bus, int devfn) > > +static struct platform_device *pci_pwrctrl_create_device(struct pci_bus *bus, int devfn) > > > + * Create pwrctrl device (if required) for the PCI device to handle the > > + * power state. If the pwrctrl device is created, then skip scanning > > + * further as the pwrctrl core will rescan the bus after powering on > > + * the device. > > I know you only moved the first sentence, but I think "power state" is > likely to be confused with the D0, D1, D2, D3hot, D3cold power > management states. Maybe we could reword this to talk about power > control, power sequencing, power supplies, power regulators or > something? > Sure. It could be changed to "power control." I hope Krzysztof can ammend it in the branch. - Mani -- மணிவண்ணன் சதாசிவம்
