On Thu, 20 Feb 2025 18:29:23 +0100, J. Neuschäfer wrote: > Add a binding for the "Gianfar" ethernet controller, also known as > TSEC/eTSEC. > > Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx> > --- > .../devicetree/bindings/net/fsl,gianfar.yaml | 242 +++++++++++++++++++++ > .../devicetree/bindings/net/fsl-tsec-phy.txt | 39 +--- > 2 files changed, 243 insertions(+), 38 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Warning: Duplicate compatible "gianfar" found in schemas matching "$id": http://devicetree.org/schemas/net/fsl,gianfar.yaml# http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: device_type:0: 'mdio' was expected from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: '#address-cells' is a required property from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: '#size-cells' is a required property from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: $nodename:0: 'ethernet@24000' does not match '^mdio(-(bus|external))?(@.+|-([0-9]+))?$' from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: Unevaluated properties are not allowed ('device_type', 'interrupts', 'local-mac-address', 'model', 'phy-handle' were unexpected) from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: device_type:0: 'mdio' was expected from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: #size-cells: 0 was expected from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: $nodename:0: 'ethernet@24000' does not match '^mdio(-(bus|external))?(@.+|-([0-9]+))?$' from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: #size-cells: 0 was expected from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: mdio@520:reg:0:0: 1312 is greater than the maximum of 31 from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: mdio@520:reg:0: [1312, 32] is too long from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/fsl,gianfar.example.dtb: ethernet@24000: Unevaluated properties are not allowed ('#size-cells', 'cell-index', 'device_type', 'interrupts', 'local-mac-address', 'mdio@520', 'model', 'ranges' were unexpected) from schema $id: http://devicetree.org/schemas/net/fsl,gianfar-mdio.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250220-gianfar-yaml-v1-3-0ba97fd1ef92@xxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
