On Mon, Feb 17, 2025 at 1:58 PM Yixun Lan <dlan@xxxxxxxxxx> wrote:
>
> Export custom function to add gpio pin range from pinctrl
> subsystem. This would make it possible to add pins to multi
> gpio chips.
>
> Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx>
> ---
> drivers/gpio/gpiolib-of.c | 5 ++++-
> include/linux/gpio/driver.h | 7 +++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 2e537ee979f3e2b6e8d5f86f3e121a66f2a8e083..64c8a153b823d65faebed9c4cd87952359b42765 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -1170,7 +1170,10 @@ int of_gpiochip_add(struct gpio_chip *chip)
> if (chip->of_gpio_n_cells > MAX_PHANDLE_ARGS)
> return -EINVAL;
>
> - ret = of_gpiochip_add_pin_range(chip);
> + if (!chip->of_add_pin_range)
> + chip->of_add_pin_range = of_gpiochip_add_pin_range;
> +
> + ret = chip->of_add_pin_range(chip);
> if (ret)
> return ret;
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 2dd7cb9cc270a68ddedbcdd5d44e0d0f88dfa785..a7b966c78a2f62075fb7804f6e96028564dda161 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -528,6 +528,13 @@ struct gpio_chip {
> */
> int (*of_xlate)(struct gpio_chip *gc,
> const struct of_phandle_args *gpiospec, u32 *flags);
> +
> + /**
> + * @of_add_pin_range:
> + *
> + * Callback to add pin ranges from pinctrl
> + */
Please, make the API contract more specific: describe the return value
and check it in the call place if it can return errors.
Also: is this even OF-specific if it doesn't take any OF argument? Why
not just add_pin_range()?
Bart
> + int (*of_add_pin_range)(struct gpio_chip *chip);
> #endif /* CONFIG_OF_GPIO */
> };
>
>
> --
> 2.48.1
>
