Re: [PATCH net-next v3 04/14] net: ethernet: qualcomm: Initialize PPE buffer management for IPQ9574

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/11/2025 9:14 PM, Andrew Lunn wrote:
+/* Assign the share buffer number 1550 to group 0 by default. */
+static const int ipq9574_ppe_bm_group_config = 1550;

To a large extent, the comment is useless. What should be in the
comment is why, not what.

	Andrew


OK, I will improve the comment to describe it better.

There are total 2048 buffers available in PPE, out of which some
buffers are reserved for some specific purposes. The rest of the
pool of 1550 buffers are assigned to the general 'group0' which
is shared among all ports of the PPE.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux