> Hi Andrew, > Thanks for the clarification. > Will post v7 with the following updates: > > 1. Changing phy-mode in dt-binding as shown below: > phy-mode: > enum: > - rgmii > - rgmii-id > - rgmii-rxid > - rgmii-txid > > 2. Removing phy-mode from .dtsi and example given in dt-binding The example can use phy-mode, since the example is the combination of the .dtsi and the .dts parts of the device tree. And having the example using 'rgmii-id' will hopefully prevent some people wrongly using 'rgmii' > 3. Add phy-mode to .dts file and specify 'rgmii-id' there. Great. History shows if you get the example and the first user correct, everybody blindly copies it and gets it right by accident. If the first user is wrong, everybody blindly copies it, and get is wrong by not sanity checking what they copy. Andrew
