> -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: 14 February 2025 05:50 > To: Swathi K S <swathi.ks@xxxxxxxxxxx> > Cc: krzk+dt@xxxxxxxxxx; andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; > edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; > robh@xxxxxxxxxx; conor+dt@xxxxxxxxxx; richardcochran@xxxxxxxxx; > mcoquelin.stm32@xxxxxxxxx; alexandre.torgue@xxxxxxxxxxx; > rmk+kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 1/2] dt-bindings: net: Add FSD EQoS device tree > bindings > > > + phy-mode: > > + enum: > > + - rgmii-id > > phy-mode is normally a board property, in the .dts file, since the board might > decide to have extra long clock lines and so want 'rgmii'. > > The only reason i can think of putting rgmii-id here is if the MAC only > supports 'rgmii-id', it is impossible to make it not add delays. > If that is true, a comment would be good. Hi Andrew, Thanks for reviewing. I think we already discussed this part some time back here [1] [1] : https://patchwork.kernel.org/project/linux-arm-kernel/patch/20230814112539.7 0453-2-sriranjani.p@xxxxxxxxxxx/#25879995 Please do let me know if there is any other concern on this. -Swathi > > Andrew
