On Wed, Dec 11, 2024 at 11:07 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Tue, Dec 10, 2024 at 02:53:37PM +0200, Daniel Baluta wrote: > > Audio block control contains a set of registers some of them used for > > DSP configuration. > > > > Drivers (rproc, SOF) are using fsl,dsp-ctrl property to access those > > registers in order to control the operations of the DSP (e.g for > > start, reset, etc). > > This should have been implemented as reset controller, not syscon. It's > really poor choice to call everything syscon. It does not scale, does > not provide you runtime PM or probe ordering (device links). Quick look > at your drivers suggest that you have exacvtly that problems. Hi Krzysztof, The bits we are using from audio-blck-ctrl for controlling the DSP are not for reset! They are only for Run/Stall the DSP. The reset is done via DAP interface. I will sent a separate patch to abstract the reset interaction using a reset controller. But for Run/Stall bits we need to use a syscon. thanks, Daniel.
