On Sat, 8 Feb 2025 16:22:09 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Fri, 7 Feb 2025 16:09:15 +0200 > Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote: > > > Add support for selecting the data format within the AXI ADC ip. > > > > Add separate complatible string for the custom AD485X IP and implement > > the necessary changes. > > > > Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > > --- > > changes in v12: > > - add separate compatible for ad485x AXI IP core. > > drivers/iio/adc/adi-axi-adc.c | 99 +++++++++++++++++++++++++++++++---- > > 1 file changed, 90 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > > index d2e1dc63775c..272d82c6e887 100644 > > --- a/drivers/iio/adc/adi-axi-adc.c > > +++ b/drivers/iio/adc/adi-axi-adc.c > > @@ -45,6 +45,12 @@ > > #define ADI_AXI_ADC_REG_CTRL 0x0044 > > #define ADI_AXI_ADC_CTRL_DDR_EDGESEL_MASK BIT(1) > > > > +#define ADI_AXI_ADC_REG_CNTRL_3 0x004c > > +#define AD485X_CNTRL_3_PACKET_FORMAT_MSK GENMASK(1, 0) > Sorry I missed this until now, but normal IIO thing is no wild cards > in naming (been bitten too often!) > > So I'd like to see these named after a specific part. Having realized this is named after the IP naming (which indeed uses the wild card), maybe we could prefix with AXI_ perhaps to make that association more obvious? > > > >
