On 11/02/2025 13:56, Crystal Guo (郭晶) wrote: >>> Signed-off-by: Crystal Guo <crystal.guo@xxxxxxxxxxxx> >>> --- >>> .../mediatek,common-dramc.yaml | 129 >>> ++++++++++++++++++ >>> 1 file changed, 129 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/memory- >>> controllers/mediatek,common-dramc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,common-dramc.yaml >>> b/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,common-dramc.yaml >>> new file mode 100644 >>> index 000000000000..c9e608c7f183 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/memory- >>> controllers/mediatek,common-dramc.yaml >>> @@ -0,0 +1,129 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +# Copyright (c) 2024 MediaTek Inc. >>> +%YAML 1.2 >>> +--- >>> +$id: >>> https://urldefense.com/v3/__http://devicetree.org/schemas/memory-controllers/mediatek,common-dramc.yaml*__;Iw!!CTRNKA9wMg0ARbw!mztYfN3n6_IAx78S44PFOetQS51-h6obm2HHrjEVRI-HJYyzJ2VWbbik2rn3pybssUBOT4gp5GD5-Mgk$ >>> +$schema: >>> https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!mztYfN3n6_IAx78S44PFOetQS51-h6obm2HHrjEVRI-HJYyzJ2VWbbik2rn3pybssUBOT4gp5AGE5Eci$ >>> + >>> +title: MediaTek Common DRAMC (DRAM Controller) >> >> Common? Is this a real thing? Please describe the hardware. >> > > Sorry, my original description was not accurate. It has been changed > to: > > Title: MediaTek DRAM Controller (DRAMC) > >>> + >>> +maintainers: >>> + - Crystal Guo <crystal.guo@xxxxxxxxxxxx> >>> + >>> +description: | >> >> Do not need '|' unless you need to preserve formatting. >> > > Okay, remove it in v2. > >>> + The DRAM controller of MediaTek SoC provides an interface to >>> + get the current data rate of DRAM. >> >> So not common here? > > Sorry, my original title description was not accurate. > >> >>> + >>> +properties: >>> + compatible: >>> + const: mediatek,common-dramc >> >> This has to be SoC. >> > > Change to "mediatek,mt8196-dramc" > >>> + >>> + reg: >>> + minItems: 9 >> >> Why this is flexible? >> > The original implementation was incorrect and has been corrected in v2 You replied to two months old review. I don't have the context and I do not have these emails in my inbox, therefore if you have any questions I cannot answer. Please implement entire feedback or discuss within reasonable amount of time. If something is unresolved, please mention it in the changelog of future versions. Best regards, Krzysztof
