On Tue, Feb 11, 2025 at 04:01:56PM +0100, Stephan Gerhold wrote: > Add the WiFi/BT nodes for QCP and describe the regulators for the WCN7850 > combo chip using the new power sequencing bindings. All voltages are > derived from chained fixed regulators controlled using a single GPIO. > > The same setup also works for CRD (and likely most of the other X1E80100 > laptops). However, unlike the QCP they use soldered or removable M.2 cards > supplied by a single 3.3V fixed regulator. The other necessary voltages are > then derived inside the M.2 card. Describing this properly requires > new bindings, so this commit only adds QCP for now. > > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> > --- > Changes in v2: > - Rebase on qcom for-next, patch 1-2 were applied already > - Mention dummy regulator warning > - Link to v1: https://lore.kernel.org/r/20241007-x1e80100-pwrseq-qcp-v1-0-f7166510ab17@xxxxxxxxxx > --- > The Linux driver currently warns about a missing regulator supply: > > pwrseq-qcom_wcn wcn7850-pmu: supply vddio1p2 not found, using dummy regulator > > This supply exists on the WCN7850 chip, but nothing is connected there on > the QCP. Discussion is still open how to hide this warning in the driver, > but since the DT is correct and the same setup is already used on SM8550 > upstream, this shouldn't block this patch. I thought Bartosz was gonna fix his driver... > @@ -337,6 +338,101 @@ usb_1_ss2_sbu_mux: endpoint { > }; > }; > }; > + > + vreg_wcn_3p3: regulator-wcn-3p3 { Please keep the nodes sorted by name. These should all go above the usb muxes. Johan
