On 10/02/2025 11:36, Sakari Ailus wrote: > Hi Krzysztof, > > On Mon, Feb 10, 2025 at 09:29:25AM +0100, Krzysztof Kozlowski wrote: >>> + dongwoon,vcm-freq: >>> + description: >>> + The switching frequency for the voice coil motor. >> >> Frequency is in Hertz, so use proper property unit suffix. BTW, you >> cannot add incorrect properties post-factum based on already accepted >> ACPI driver. This would be nice bypass of review, right? > > What's actually configured here is the divisor (10 MHz clock, divisor seems > to be value + 2). It's similar to existing > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml . I prefer > this as it's much easier to use that in a driver (think of having values > like 1428571 in DT, too). Sure, but then this should be renamed to match purpose and description rephrased. > >> >>> + $ref: /schemas/types.yaml#/definitions/uint32 And this would stay + constraints. Best regards, Krzysztof
