Hi Krzysztof, On Mon, Feb 10, 2025 at 09:29:25AM +0100, Krzysztof Kozlowski wrote: > > + dongwoon,vcm-freq: > > + description: > > + The switching frequency for the voice coil motor. > > Frequency is in Hertz, so use proper property unit suffix. BTW, you > cannot add incorrect properties post-factum based on already accepted > ACPI driver. This would be nice bypass of review, right? What's actually configured here is the divisor (10 MHz clock, divisor seems to be value + 2). It's similar to existing Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml . I prefer this as it's much easier to use that in a driver (think of having values like 1428571 in DT, too). > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Drop. > > minimum/maximum constraints > > > + > > No reset/powerdown gpios in the hardware? > > Missing required block. > > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: dongwoon,dw9718s > > + then: > > + properties: > > + dongwoon,vcm-freq: > > + default: 0 > > + enum: > > + - 0 # 5.00 MHz > > + - 1 # 3.33 MHz > > + - 2 # 2.50 MHz > > + - 3 # 2.00 MHz > > + - 4 # 1.67 MHz > > + - 5 # 1.43 MHz > > + - 6 # 1.25 MHz > > + - 7 # 1.11 MHz > > + - 8 # 1.00 MHz > > + - 9 # 0.91 MHz > > + - 10 # 0.83 MHz > > + - 11 # 0.77 MHz > > + - 12 # 0.71 MHz > > + - 13 # 0.67 MHz > > + - 14 # 0.63 MHz > > + - 15 # 0.59 MHz > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: dongwoon,dw9719 > > + then: > > + properties: > > + dongwoon,vcm-freq: > > + default: 0x60 -- Regards, Sakari Ailus
