On Mon, Feb 10, 2025 at 10:56:30AM +0800, Chen Wang wrote: > > On 2025/2/10 9:20, Yixun Lan wrote: > > Hi Chen: > > > > On 08:55 Mon 10 Feb , Chen Wang wrote: > > > On 2025/2/9 20:29, Inochi Amaoto wrote: > > > > Add reset generator node for all CV18XX series SoC. > > > > > > > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> > > > > --- > > > > arch/riscv/boot/dts/sophgo/cv18xx-reset.h | 98 +++++++++++++++++++++++ > > > Why it's not include/dt-bindings/reset/sophgo,cv18xx-reset.h? > > > > > then first need to answer if it's really a binding, there are some disucssions > > I personally favor Inochi's way here > > > > https://lore.kernel.org/linux-devicetree/c7e243e3-3f61-4d63-8727-3837838bdfcc@xxxxxxxxxx > > https://lore.kernel.org/linux-devicetree/c088e01c-0714-82be-8347-6140daf56640@xxxxxxxxxx/ > > Well, it's fine if you don't want to define it as binding just because the > ids are not continuous. In fact, for simple-reset, I think there is no big > problem to define it as bindings. > I add this as a dts header because it is a device abi, not a binding one. > Actually, in the first link upon, I see Krzysztof also said "simple-reset is > an exception." > > I recall we ever discussed this when Jisheng submitted the first version of > reset driver for cv18xx. FYI. See https://lore.kernel.org/linux-riscv/42ad3f60-2755-4d3b-a766-8e4404f76a7c@xxxxxxxxxx/. > Yeah, I have seen this. But due to the previous reason, I will hold this and see whether there are any new discussions. Regards, Inochi
